Issue 11907007: Add base class cr.ui.BubbleButton for options.ControlledSettingIndicator

Issue 11907007: Add base class cr.ui.BubbleButton for options.ControlledSettingIndicator (Closed)

Created:
7 years, 11 months ago by bartfab (slow)

Modified:
7 years, 11 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add base class cr.ui.BubbleButton for options.ControlledSettingIndicator Re-landing. The test failure this was reverted for is unrelated (the failure was in native UI, this is a WebUI change). This CL extracts a cr.ui.BubbleButton base class from the options.ControlledSettingIndicator so that it can be shared with the upcoming improved about:policy page. BUG=134849 TEST=Manual TBR=jhawkins@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176946

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+115 lines, -77 lines)			Patch
chrome/browser/resources/options/controlled_setting.js	View	4 chunks	+3 lines, -59 lines	0 comments	Download
chrome/browser/resources/options/options.html	View	2 chunks	+2 lines, -0 lines	0 comments	Download
chrome/browser/resources/options/options_page.css	View	1 chunk	+2 lines, -18 lines	0 comments	Download
chrome/browser/resources/shared/css/bubble_button.css	View	1 chunk	+20 lines, -0 lines	0 comments	Download
chrome/browser/resources/shared/js/cr/ui/bubble_button.js	View	1 chunk	+84 lines, -0 lines	0 comments	Download
chrome/browser/resources/shared_resources.grd	View	2 chunks	+4 lines, -0 lines	0 comments	Download