Issue 11906007: net: don't pin crypto.cat's subdomains. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(70)

My Issues | Starred Open | Closed | All

Issue 11906007: net: don't pin crypto.cat's subdomains. (Closed)

Created:
7 years, 11 months ago by agl

Modified:
7 years, 11 months ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

net: don't pin crypto.cat's subdomains. By request of Nadim Kobeissi. BUG=169788 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176999

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	net/base/transport_security_state_static.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	net/base/transport_security_state_static.json	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	net/base/transport_security_state_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/11906007/1

7 years, 11 months ago (2013-01-15 19:09:59 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/11906007/1

7 years, 11 months ago (2013-01-15 19:11:17 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/11906007/1

7 years, 11 months ago (2013-01-15 19:13:49 UTC) #5

commit-bot: I haz the power

Presubmit check for 11906007-1 failed and returned exit status 1. Running presubmit commit checks ...

7 years, 11 months ago (2013-01-15 19:14:13 UTC) #6

Presubmit check for 11906007-1 failed and returned exit status 1.

Running presubmit commit checks ...
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 43, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1259, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1107, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1024, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 798, in CheckChangeOnCommit
  File "<string>", line 680, in _CommonChecks
  File "/b/depot_tools/presubmit_canned_checks.py", line 966, in
PanProjectChecks
    input_api, output_api, source_file_filter=None))
  File "/b/depot_tools/presubmit_canned_checks.py", line 784, in CheckOwners
    approval_needed=input_api.is_committing)
  File "/b/depot_tools/presubmit_canned_checks.py", line 826, in
_RietveldOwnerAndReviewers
    issue_props = _GetRietveldIssueProps(input_api, True)
  File "/b/depot_tools/presubmit_canned_checks.py", line 817, in
_GetRietveldIssueProps
    issue=int(issue), messages=messages)
  File "/b/depot_tools/rietveld.py", line 439, in get_issue_properties
    super(CachingRietveld, self).get_issue_properties)
  File "/b/depot_tools/rietveld.py", line 418, in _lookup
    function_cache[args] = update(*args)
  File "/b/depot_tools/rietveld.py", line 93, in get_issue_properties
    return json.loads(self.get(url))
  File "/b/depot_tools/rietveld.py", line 352, in get
    return self._send(request_path, **kwargs)
  File "/b/depot_tools/rietveld.py", line 378, in _send
    result = self.rpc_server.Send(request_path, **kwargs)
  File "/b/depot_tools/third_party/upload.py", line 416, in Send
    ErrorExit(e.read())
  File "/b/depot_tools/rietveld.py", line 370, in trap_http_500
    raise urllib2.HTTPError(request_path, m.group(1), msg, None, None)
urllib2.HTTPError: HTTP Error 500: 
<html><head>
<meta http-equiv="content-type" content="text/html;charset=utf-8">
<title>500 Server Error</title>
</head>
<body text=#000000 bgcolor=#ffffff>
<h1>Error: Server Error</h1>
<h2>The server encountered an error and could not complete your request.<p>If
the problem persists, please <A
HREF="http://code.google.com/appengine/community.html">report</A> your problem
and mention this error message and the query that caused it.</h2>
<h2></h2>
</body></html>

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/11906007/1

7 years, 11 months ago (2013-01-15 20:27:59 UTC) #7

Message was sent while issue was closed.

Change committed as 176999

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698