android_webview/tools/WebViewTelemetryShell/AndroidManifest.xml - Issue 1190103002: Make lint fail builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/tools/WebViewTelemetryShell/AndroidManifest.xml

Issue 1190103002: Make lint fail builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: set android_webview to use minsdk 19 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/tools/WebViewTelemetryShell/AndroidManifest.xml

diff --git a/android_webview/tools/WebViewTelemetryShell/AndroidManifest.xml b/android_webview/tools/WebViewTelemetryShell/AndroidManifest.xml

index dbdda35c7c637dda51144dd22c5f15cc157e0749..66cb683e4c65114bc33f7d7684dd39b61ede3a03 100644

--- a/android_webview/tools/WebViewTelemetryShell/AndroidManifest.xml

+++ b/android_webview/tools/WebViewTelemetryShell/AndroidManifest.xml

@@ -9,8 +9,7 @@

android:versionCode="1"

android:versionName="1.0" >

- <uses-sdk android:minSdkVersion="17"

- android:targetSdkVersion="19" />

+ <uses-sdk android:minSdkVersion="19" android:targetSdkVersion="19" />

boliu 2015/06/18 20:26:58 this doesn't exist anymore: https://codereview.chr

aurimas (slooooooooow) 2015/06/18 21:37:54 Done

<uses-permission android:name="android.permission.INTERNET" />

<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>