chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/QueryInOmniboxTest.java - Issue 1190103002: Make lint fail builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/QueryInOmniboxTest.java

Issue 1190103002: Make lint fail builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix exported crash for ChromeShellTest Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/compositor/layouts/MockResourcesForLayout.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImplTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/QueryInOmniboxTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/QueryInOmniboxTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/QueryInOmniboxTest.java

index eefff10ad59f5265b13ef11eb85044c72e435d7c..ff800b8a026a30ecc32b8162f32d96168b5ed01c 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/QueryInOmniboxTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/QueryInOmniboxTest.java

@@ -35,6 +35,7 @@ import org.chromium.chrome.test.util.TestHttpServerClient;

import org.chromium.content.browser.test.util.KeyUtils;

import java.util.List;

+import java.util.Locale;

import java.util.Map;

import java.util.concurrent.Callable;

import java.util.concurrent.atomic.AtomicInteger;

@@ -202,7 +203,7 @@ public class QueryInOmniboxTest extends ChromeActivityTestCaseBase<ChromeActivit

* @throws InterruptedException

private void setupAutocompleteSuggestions(final String term) throws InterruptedException {

- final String suggestionFor = term.toLowerCase();

+ final String suggestionFor = term.toLowerCase(Locale.US);

Map<String, List<SuggestionsResult>> suggestionsMap = buildSuggestionMap(

new TestSuggestionResultsBuilder()

.setTextShownFor(suggestionFor)