chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java - Issue 1190103002: Make lint fail builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java

Issue 1190103002: Make lint fail builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix exported crash for ChromeShellTest Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java

index 8330308e65138062719e56faac10dddce092e898..5ca8f3274fa03e88e4f2261762d2bfb1f866c5bc 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java

@@ -35,6 +35,7 @@ import org.chromium.content.browser.test.util.UiUtils;

import org.chromium.net.test.util.TestWebServer;

import java.net.URLEncoder;

+import java.util.Locale;

import java.util.concurrent.Callable;

import java.util.concurrent.ExecutionException;

import java.util.concurrent.Semaphore;

@@ -324,25 +325,25 @@ public class NavigateTest extends ChromeTabbedActivityTestBase {

for (int i = 0; i < repeats; i++) {

singleClickView(getActivity().findViewById(R.id.back_button));

UiUtils.settleDownUI(getInstrumentation());

- assertEquals(String.format(

+ assertEquals(String.format(Locale.US,

"URL mismatch after pressing back button for the 1st time in repetition %d.",

i), urls[1], getActivity().getActivityTab().getUrl());

singleClickView(getActivity().findViewById(R.id.back_button));

UiUtils.settleDownUI(getInstrumentation());

- assertEquals(String.format(

+ assertEquals(String.format(Locale.US,

"URL mismatch after pressing back button for the 2nd time in repetition %d.",

i), urls[0], getActivity().getActivityTab().getUrl());

singleClickView(getActivity().findViewById(R.id.forward_button));

UiUtils.settleDownUI(getInstrumentation());

- assertEquals(String.format(

+ assertEquals(String.format(Locale.US,

"URL mismatch after pressing fwd button for the 1st time in repetition %d.", i),

urls[1], getActivity().getActivityTab().getUrl());

singleClickView(getActivity().findViewById(R.id.forward_button));

UiUtils.settleDownUI(getInstrumentation());

- assertEquals(String.format(

+ assertEquals(String.format(Locale.US,

"URL mismatch after pressing fwd button for the 2nd time in repetition %d.", i),

urls[2], getActivity().getActivityTab().getUrl());

}