chrome/browser/ui/browser_command_controller.cc - Issue 11896104: Refactor FullscreenController removing TogglePresentationMode & adding ToggleFullscreenWithChrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 11896104: Refactor FullscreenController removing TogglePresentationMode & adding ToggleFullscreenWithChrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm compile fix Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_command_controller.cc

diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc

index 72ce592df0f30d8f04bedba3729052a0a7ff884d..60f0fe9512cf9fa63c1c092e6c4589bcf08870df 100644

--- a/chrome/browser/ui/browser_command_controller.cc

+++ b/chrome/browser/ui/browser_command_controller.cc

@@ -39,6 +39,10 @@

#include "content/public/common/url_constants.h"

#include "ui/base/keycodes/keyboard_codes.h"

+#if defined(OS_MACOSX)

+#include "chrome/browser/ui/browser_commands_mac.h"

+#endif

#if defined(OS_WIN)

#include "base/win/metro.h"

#endif

@@ -421,7 +425,11 @@ void BrowserCommandController::ExecuteCommandWithDisposition(

ConvertPopupToTabbedBrowser(browser_);

break;

case IDC_FULLSCREEN:

+#if defined(OS_MACOSX)

+ chrome::ToggleFullscreenWithChrome(browser_);

+#else

chrome::ToggleFullscreenMode(browser_);

+#endif

break;

#if defined(USE_ASH)

@@ -450,7 +458,7 @@ void BrowserCommandController::ExecuteCommandWithDisposition(

#if defined(OS_MACOSX)

case IDC_PRESENTATION_MODE:

- browser_->TogglePresentationMode();

+ chrome::ToggleFullscreenMode(browser_);

break;

#endif

case IDC_EXIT:

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/browser_commands_mac.h » ('j') | no next file with comments »