Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 11896088: Fix android build error with gcc 4.7.2 (Closed)

Created:
7 years, 11 months ago by Sungmann Cho (Inactive)
Modified:
7 years, 10 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Fix android build error with gcc 4.7.2. Compiling the latest source tree with gcc 4.7.2 currently breaks at: ../../tools/android/forwarder2/socket.cc: In member function ‘int forwarder2::Socket::Read(void*, size_t)’: ../../tools/android/forwarder2/socket.cc:323:13: error: ‘read’ was not declared in this scope ../../tools/android/forwarder2/socket.cc:323:13: error: invalid type in declaration before ‘;’ token [2269/11351] CXX obj/chrome/app/policy/gen...ettings_proto_compile.chrome_settings.pb.o ninja: build stopped: subcommand failed. It seems that 'tools/android/forwarder2/socket.cc' needs '#include <unistd.h>. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179569

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/android/forwarder2/socket.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Sungmann Cho (Inactive)
7 years, 11 months ago (2013-01-24 10:41:18 UTC) #1
felipeg
lgtm
7 years, 11 months ago (2013-01-24 10:56:07 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 11 months ago (2013-01-24 11:35:57 UTC) #3
Xianzhu
7 years, 11 months ago (2013-01-24 17:13:16 UTC) #4
bulach
lgtm, thanks!
7 years, 11 months ago (2013-01-24 17:20:04 UTC) #5
Isaac (away)
Drive By: Needs a better title and description. For CQ, it uses the first line ...
7 years, 11 months ago (2013-01-24 18:10:31 UTC) #6
Sungmann Cho (Inactive)
I modified the issue title and description.
7 years, 11 months ago (2013-01-25 00:18:34 UTC) #7
Isaac (away)
Thanks, looks better. LGTM
7 years, 11 months ago (2013-01-25 00:19:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Sungmann.Cho@gmail.com/11896088/1
7 years, 11 months ago (2013-01-25 01:55:35 UTC) #9
commit-bot: I haz the power
Presubmit check for 11896088-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-25 01:55:38 UTC) #10
Sungmann Cho (Inactive)
I added the AUTHORS. It's my first patch ;-)
7 years, 11 months ago (2013-01-25 02:47:59 UTC) #11
Isaac (away)
looks like you're missing the change now.
7 years, 11 months ago (2013-01-25 02:48:31 UTC) #12
Sungmann Cho (Inactive)
I'm sorry for the missing.
7 years, 11 months ago (2013-01-25 02:58:40 UTC) #13
Isaac (away)
lgtm. To committers: Verified agreement was signed.
7 years, 11 months ago (2013-01-25 03:08:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Sungmann.Cho@gmail.com/11896088/6003
7 years, 11 months ago (2013-01-25 03:08:41 UTC) #15
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=92840
7 years, 11 months ago (2013-01-25 04:47:31 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Sungmann.Cho@gmail.com/11896088/6003
7 years, 10 months ago (2013-01-30 05:57:29 UTC) #17
commit-bot: I haz the power
7 years, 10 months ago (2013-01-30 09:14:32 UTC) #18
Message was sent while issue was closed.
Change committed as 179569

Powered by Google App Engine
This is Rietveld 408576698