Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 11896029: Remove use_ibus variable from gyp file. (Closed)

Created:
7 years, 11 months ago by Seigo Nonaka
Modified:
7 years, 11 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Remove use_ibus variable from gyp file. We can remove use_ibus flag because the ibus dependency was gone. BUG=None TEST=try bots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -55 lines) Patch
M ash/ash.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M build/common.gypi View 4 chunks +0 lines, -5 lines 0 comments Download
M build/linux/system.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/ui.gyp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Seigo Nonaka
7 years, 11 months ago (2013-01-22 12:36:24 UTC) #1
satorux1
LGTM
7 years, 11 months ago (2013-01-22 17:01:11 UTC) #2
Seigo Nonaka
satorux: Thank you for you review. adding ben@ as the owner of ui/ ash/ chrome/ ...
7 years, 11 months ago (2013-01-23 08:17:50 UTC) #3
Ben Goodger (Google)
lgtm
7 years, 11 months ago (2013-01-23 22:15:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11896029/1
7 years, 11 months ago (2013-01-24 03:46:56 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_net_tests, sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=102886
7 years, 11 months ago (2013-01-24 04:57:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11896029/1
7 years, 11 months ago (2013-01-24 11:01:20 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-24 14:43:39 UTC) #8
Message was sent while issue was closed.
Change committed as 178568

Powered by Google App Engine
This is Rietveld 408576698