Issue 11889031: Merged r13380, r13381 into trunk branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11889031: Merged r13380, r13381 into trunk branch. (Closed)

Created:
7 years, 11 months ago by Yang

Modified:
7 years, 11 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/trunk

Visibility:
Public.

Merged r13380, r13381 into trunk branch. Add sanity check to CodeFlusher::AddCandidate. Fix windows build wrt symbol export. BUG=chromium:169209 R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13384

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -3 lines)			Patch
M	include/v8.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mark-compact.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/mark-compact.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Michael Starzinger

7 years, 11 months ago (2013-01-15 10:40:06 UTC) #2

LGTM (reviewed version.cc and rubber-stamped the rest).