Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 11889029: Minor style cleanup in the PhoneField class: (Closed)

Created:
7 years, 11 months ago by Ilya Sherman
Modified:
7 years, 11 months ago
Reviewers:
dhollowa
CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman
Visibility:
Public.

Description

Minor style cleanup in the PhoneField class: * Inline ParseInternal() into Parse() * Rename a constant to have kConstantNamingStyle * Make GetRegExp a private static method (note that this can't be moved into the anonymous namespace since it depends on the private RegexType enum). * Remove unnecessary PhoneField:: prefixes * Adjust ordering of declarations and definitions within header and implementation files. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177095

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -162 lines) Patch
M chrome/browser/autofill/phone_field.h View 3 chunks +13 lines, -17 lines 0 comments Download
M chrome/browser/autofill/phone_field.cc View 4 chunks +136 lines, -145 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Ilya Sherman
https://chromiumcodereview.appspot.com/11889029/diff/1/chrome/browser/autofill/phone_field.cc File chrome/browser/autofill/phone_field.cc (right): https://chromiumcodereview.appspot.com/11889029/diff/1/chrome/browser/autofill/phone_field.cc#newcode194 chrome/browser/autofill/phone_field.cc:194: &phone_field->parsed_phone_fields_[FIELD_EXTENSION]); Lines 125-194 were just copy/pasted, with the only ...
7 years, 11 months ago (2013-01-15 22:17:33 UTC) #1
dhollowa
lgtm
7 years, 11 months ago (2013-01-16 00:45:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11889029/1
7 years, 11 months ago (2013-01-16 00:52:38 UTC) #3
commit-bot: I haz the power
Retried try job too often on win for step(s) compile
7 years, 11 months ago (2013-01-16 03:12:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11889029/1
7 years, 11 months ago (2013-01-16 04:12:23 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 05:42:10 UTC) #6
Message was sent while issue was closed.
Change committed as 177095

Powered by Google App Engine
This is Rietveld 408576698