Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2372)

Issue 11889017: some fixes and warning disables in ui/ for building on win x64 (Closed)

Created:
7 years, 11 months ago by scottmg
Modified:
7 years, 11 months ago
CC:
chromium-reviews, dcheng
Visibility:
Public.

Description

some fixes and warning disables in ui/ for building on win x64 - Some |int|s that should be |ptrdiff_t|s. - Icon structures are packing to known size (same signs). - GetWindowLong needs to be GetWindowLongPtr to work on 32 & 64. R=ben@chromium.org, jschuh@chromium.org BUG=167187, 166496 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176860

Patch Set 1 #

Total comments: 8

Patch Set 2 : review fixes #

Patch Set 3 : dcheck->check #

Patch Set 4 : remove stupid code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M ui/base/dragdrop/os_exchange_data_provider_win.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M ui/base/range/range.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/range/range_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/base/win/dpi.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/win/hwnd_subclass.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/icon_util.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M ui/gfx/text_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ui.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
scottmg
justin: review ben: owners
7 years, 11 months ago (2013-01-14 21:13:06 UTC) #1
jschuh
https://codereview.chromium.org/11889017/diff/1/ui/base/dragdrop/os_exchange_data_provider_win.cc File ui/base/dragdrop/os_exchange_data_provider_win.cc (right): https://codereview.chromium.org/11889017/diff/1/ui/base/dragdrop/os_exchange_data_provider_win.cc#newcode969 ui/base/dragdrop/os_exchange_data_provider_win.cc:969: std::min(static_cast<unsigned int>(file_name.size()), MAX_PATH - 1u)); This should be: std::min(file_name.size(), ...
7 years, 11 months ago (2013-01-14 21:31:39 UTC) #2
scottmg
https://codereview.chromium.org/11889017/diff/1/ui/base/dragdrop/os_exchange_data_provider_win.cc File ui/base/dragdrop/os_exchange_data_provider_win.cc (right): https://codereview.chromium.org/11889017/diff/1/ui/base/dragdrop/os_exchange_data_provider_win.cc#newcode969 ui/base/dragdrop/os_exchange_data_provider_win.cc:969: std::min(static_cast<unsigned int>(file_name.size()), MAX_PATH - 1u)); On 2013/01/14 21:31:39, Justin ...
7 years, 11 months ago (2013-01-14 21:45:00 UTC) #3
jschuh
lgtm, with the bitmap change. https://codereview.chromium.org/11889017/diff/1/ui/base/range/range_win.cc File ui/base/range/range_win.cc (right): https://codereview.chromium.org/11889017/diff/1/ui/base/range/range_win.cc#newcode37 ui/base/range/range_win.cc:37: const LONG kLONGMax = ...
7 years, 11 months ago (2013-01-14 22:14:35 UTC) #4
scottmg
On 2013/01/14 22:14:35, Justin Schuh wrote: > lgtm, with the bitmap change. > ... > ...
7 years, 11 months ago (2013-01-14 22:17:53 UTC) #5
Ben Goodger (Google)
lgtm
7 years, 11 months ago (2013-01-15 00:19:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11889017/8001
7 years, 11 months ago (2013-01-15 00:56:19 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-15 08:52:33 UTC) #8
Message was sent while issue was closed.
Change committed as 176860

Powered by Google App Engine
This is Rietveld 408576698