Fix a bug where the HTML content in a v2 app window wouldn't be initially focused.

Fix a bug where the HTML content in a v2 app window wouldn't be initially focused.

BUG=159450
R=rsesek@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177111

[Robert Sesek, 2013-01-14 16:36:08]

I think Avi would be a better reviewer for this.

[Avi (use Gerrit), 2013-01-14 17:10:03]

https://codereview.chromium.org/11889004/diff/1/chrome/browser/ui/cocoa/exten...
File chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.mm (right):

https://codereview.chromium.org/11889004/diff/1/chrome/browser/ui/cocoa/exten...
chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.mm:648: const
content::NotificationDetails& details) {
bad indentation

https://codereview.chromium.org/11889004/diff/1/chrome/browser/ui/cocoa/exten...
chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.mm:652:
rwhv->Focus();
I'm not clear on why this wouldn't be working. Is it because the window is
frameless?

[sail, 2013-01-14 17:17:49]

How does this work on Views. Can we do something to match their behavior?
Also, this needs a test.

[jeremya, 2013-01-15 05:49:52]

Views handles this problem more or less the same way, see
ui/views/controls/webview/webview.cc (WebView::RenderViewHostChanged).

https://codereview.chromium.org/11889004/diff/1/chrome/browser/ui/cocoa/exten...
File chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.mm (right):

https://codereview.chromium.org/11889004/diff/1/chrome/browser/ui/cocoa/exten...
chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.mm:652:
rwhv->Focus();
On 2013/01/14 17:10:03, Avi wrote:
> I'm not clear on why this wouldn't be working. Is it because the window is
> frameless?

The bug happens even for non-frameless windows.

I think Browser::UpdateUIForNavigationInTab handles this for normal browser
windows (it uses web_contents()->Focus(), which does the same thing -- I've
updated this code to do that).

[sail, 2013-01-15 15:36:52]

LGTM

[Avi (use Gerrit), 2013-01-15 15:56:33]

lgtm

okes

[commit-bot: I haz the power, 2013-01-16 00:57:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/11889004/6001

[commit-bot: I haz the power, 2013-01-16 03:05:48]

Retried try job too often on win_rel for step(s) chrome_frame_net_tests,
sync_integration_tests

[commit-bot: I haz the power, 2013-01-16 03:24:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/11889004/19001

[commit-bot: I haz the power, 2013-01-16 09:12:15]

Change committed as 177111