Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7128)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 11889003: Fixing ESC in instant-extended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
index cbc614cf81216bd67bd078f10ba355b0663126d1..2a8b73ffdd58bc9dff75de8c5970948449d6de99 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
@@ -588,11 +588,13 @@ void OmniboxViewViews::ApplyCaretVisibility() {
void OmniboxViewViews::OnTemporaryTextMaybeChanged(
const string16& display_text,
- bool save_original_selection) {
+ bool save_original_selection,
+ bool notify_text_changed) {
if (save_original_selection)
textfield_->GetSelectedRange(&saved_temporary_selection_);
- SetWindowTextAndCaretPos(display_text, display_text.length(), false, true);
+ SetWindowTextAndCaretPos(display_text, display_text.length(), false,
+ notify_text_changed);
}
bool OmniboxViewViews::OnInlineAutocompleteTextMaybeChanged(
@@ -608,7 +610,6 @@ bool OmniboxViewViews::OnInlineAutocompleteTextMaybeChanged(
void OmniboxViewViews::OnRevertTemporaryText() {
textfield_->SelectRange(saved_temporary_selection_);
- TextChanged();
}
void OmniboxViewViews::OnBeforePossibleChange() {
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_views.h ('k') | chrome/browser/ui/views/omnibox/omnibox_view_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698