Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3245)

Unified Diff: chrome/renderer/searchbox/searchbox.cc

Issue 11889003: Fixing ESC in instant-extended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reworked to send ESC down to JS, added test. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/searchbox/searchbox.cc
diff --git a/chrome/renderer/searchbox/searchbox.cc b/chrome/renderer/searchbox/searchbox.cc
index 223c320df5a7b08552eb2b2c6ca7a22ba55eb3cb..b256416cd62ed05c0ae4e39da22f031a1e1f6d9d 100644
--- a/chrome/renderer/searchbox/searchbox.cc
+++ b/chrome/renderer/searchbox/searchbox.cc
@@ -122,6 +122,8 @@ bool SearchBox::OnMessageReceived(const IPC::Message& message) {
OnAutocompleteResults)
IPC_MESSAGE_HANDLER(ChromeViewMsg_SearchBoxUpOrDownKeyPressed,
OnUpOrDownKeyPressed)
+ IPC_MESSAGE_HANDLER(ChromeViewMsg_SearchBoxEscKeyPressed,
+ OnEscKeyPressed)
IPC_MESSAGE_HANDLER(ChromeViewMsg_SearchBoxModeChanged,
OnModeChanged)
IPC_MESSAGE_HANDLER(ChromeViewMsg_SearchBoxSetDisplayInstantResults,
@@ -229,6 +231,14 @@ void SearchBox::OnUpOrDownKeyPressed(int count) {
}
}
+void SearchBox::OnEscKeyPressed() {
+ if (render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) {
+ DVLOG(1) << render_view() << " OnKeyPress ESC";
+ extensions_v8::SearchBoxExtension::DispatchEscKeyPress(
+ render_view()->GetWebView()->mainFrame());
+ }
+}
+
void SearchBox::OnKeyCaptureChange(bool is_key_capture_enabled) {
if (is_key_capture_enabled != is_key_capture_enabled_ &&
render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) {

Powered by Google App Engine
This is Rietveld 408576698