Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Unified Diff: chrome/browser/ui/omnibox/omnibox_view.h

Issue 11889003: Fixing ESC in instant-extended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reworked to send ESC down to JS, added test. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/omnibox/omnibox_view.h
diff --git a/chrome/browser/ui/omnibox/omnibox_view.h b/chrome/browser/ui/omnibox/omnibox_view.h
index 24484132e8fa6ef055ce8f467d8f04dd1b3ffa58..db3c828d75cb66a729a300e098de90266ba8a794 100644
--- a/chrome/browser/ui/omnibox/omnibox_view.h
+++ b/chrome/browser/ui/omnibox/omnibox_view.h
@@ -106,7 +106,8 @@ class OmniboxView {
const string16& display_text,
bool update_popup);
- // Sets the window text and the caret position.
+ // Sets the window text and the caret position. |notify_text_changed| is true
+ // if the model should be notified of the change.
virtual void SetWindowTextAndCaretPos(const string16& text,
size_t caret_pos,
bool update_popup,
@@ -160,9 +161,11 @@ class OmniboxView {
// Called when the temporary text in the model may have changed.
// |display_text| is the new text to show; |save_original_selection| is true
// when there wasn't previously a temporary text and thus we need to save off
- // the user's existing selection.
+ // the user's existing selection. |notify_text_changed| is true if the model
+ // should be notified of the change.
virtual void OnTemporaryTextMaybeChanged(const string16& display_text,
- bool save_original_selection) = 0;
+ bool save_original_selection,
+ bool notify_text_changed) = 0;
// Called when the inline autocomplete text in the model may have changed.
// |display_text| is the new text to show; |user_text_length| is the length of

Powered by Google App Engine
This is Rietveld 408576698