Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7780)

Unified Diff: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

Issue 11889003: Fixing ESC in instant-extended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reworked to send ESC down to JS, added test. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc
diff --git a/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc b/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc
index bd3d72ae66fd5737b4190fcacdceed310b02ec50..b3103dbc5f0c703dd425fd7a054c8b45b9ecca2f 100644
--- a/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc
+++ b/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc
@@ -573,14 +573,16 @@ void OmniboxViewGtk::UpdatePopup() {
void OmniboxViewGtk::OnTemporaryTextMaybeChanged(
const string16& display_text,
- bool save_original_selection) {
+ bool save_original_selection,
+ bool notify_text_changed) {
if (save_original_selection)
saved_temporary_selection_ = GetSelection();
StartUpdatingHighlightedText();
SetWindowTextAndCaretPos(display_text, display_text.length(), false, false);
FinishUpdatingHighlightedText();
- TextChanged();
+ if (notify_text_changed)
+ TextChanged();
}
bool OmniboxViewGtk::OnInlineAutocompleteTextMaybeChanged(
@@ -601,7 +603,6 @@ void OmniboxViewGtk::OnRevertTemporaryText() {
StartUpdatingHighlightedText();
SetSelectedRange(saved_temporary_selection_);
FinishUpdatingHighlightedText();
- TextChanged();
beaudoin 2013/02/07 22:34:59 Shamelessly getting rid of that (see explanation i
}
void OmniboxViewGtk::OnBeforePossibleChange() {

Powered by Google App Engine
This is Rietveld 408576698