chrome/browser/instant/instant_controller.h - Issue 11889003: Fixing ESC in instant-extended.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/instant/instant_controller.h

Issue 11889003: Fixing ESC in instant-extended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reworked to send ESC down to JS, added test. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/instant/instant_controller.h

diff --git a/chrome/browser/instant/instant_controller.h b/chrome/browser/instant/instant_controller.h

index 40bbfc8d756f97df7cdb46831f7a3367d8040dc0..aae153ef318d025312b0143f4b8861cbd8eef9a2 100644

--- a/chrome/browser/instant/instant_controller.h

+++ b/chrome/browser/instant/instant_controller.h

@@ -90,6 +90,11 @@ class InstantController {

// handled the key press.

bool OnUpOrDownKeyPressed(int count);

+ // Called when the user has arrowed into the selections but want to cancel,

+ // typically by pressing ESC. The omnibox text is expected to have been

+ // reverted by Chrome prior to calling this.

+ bool OnCancel();

// The preview WebContents. May be NULL. InstantController retains ownership.

content::WebContents* GetPreviewContents() const;