Issue 11888026: Rename all of the VariationIDs to use CAPS_CASE rather than CamelCase.

Issue 11888026: Rename all of the VariationIDs to use CAPS_CASE rather than CamelCase. (Closed)

Created:
7 years, 11 months ago by SteveT

Modified:
7 years, 11 months ago

Reviewers:
Alexei Svitkine (slow), sky

CC:
chromium-reviews, MAD, James Su, Ilya Sherman, jar (doing other things)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Rename all of the VariationIDs to use CAPS_CASE rather than CamelCase. TEST=No user visible changes. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177158

Patch Set 3 : fix unittests #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -92 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_field_trial.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chrome_browser_field_trials.cc	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/metrics/variations/variations_http_header_provider.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/metrics/variations/variation_ids.h	View	1	5 chunks	+51 lines, -52 lines	0 comments	Download
M	chrome/common/metrics/variations/variations_util.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/metrics/variations/variations_util_unittest.cc	View	1 2	6 chunks	+26 lines, -26 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

SteveT

Hey all, Alexei - review. Scott - OWNERS for autocomplete. Also, here's the patch I ...

7 years, 11 months ago (2013-01-15 18:06:54 UTC) #1

sky

Nice, LGTM https://codereview.chromium.org/11888026/diff/2001/chrome/common/metrics/variations/variation_ids.h File chrome/common/metrics/variations/variation_ids.h (right): https://codereview.chromium.org/11888026/diff/2001/chrome/common/metrics/variations/variation_ids.h#newcode129 chrome/common/metrics/variations/variation_ids.h:129: SUGGEST_TRIAL_STARTED_2012Q4_ID_MIN = 3310029, nit: To make this ...

7 years, 11 months ago (2013-01-15 18:10:03 UTC) #2

SteveT

Thanks! Waiting on an approval from Alexei now. https://codereview.chromium.org/11888026/diff/2001/chrome/common/metrics/variations/variation_ids.h File chrome/common/metrics/variations/variation_ids.h (right): https://codereview.chromium.org/11888026/diff/2001/chrome/common/metrics/variations/variation_ids.h#newcode129 chrome/common/metrics/variations/variation_ids.h:129: SUGGEST_TRIAL_STARTED_2012Q4_ID_MIN ...

7 years, 11 months ago (2013-01-15 18:21:42 UTC) #3

SteveT

Yeah, the bots are having issues fetching the patch due to an outage.

7 years, 11 months ago (2013-01-15 19:15:02 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/11888026/16001

7 years, 11 months ago (2013-01-16 15:20:10 UTC) #7

Message was sent while issue was closed.

Change committed as 177158

Expand Messages | Collapse Messages