Issue 11888022: Fix windows build wrt symbol export.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11888022: Fix windows build wrt symbol export. (Closed)

Created:
7 years, 11 months ago by Yang

Modified:
7 years, 11 months ago

Reviewers:
dcarney, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix windows build wrt symbol export. R=dcarney@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13381

Patch Set 1 #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	include/v8.h	View		2 chunks	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

7 years, 11 months ago (2013-01-15 10:40:59 UTC) #3

Message was sent while issue was closed.

Drive-by nit. :)

https://chromiumcodereview.appspot.com/11888022/diff/1/include/v8.h
File include/v8.h (right):

https://chromiumcodereview.appspot.com/11888022/diff/1/include/v8.h#newcode1138
include/v8.h:1138: int start = 0,
Nit of the day: Indentation is off.

Expand Messages | Collapse Messages