Issue 11888016: Workaround to make MemoryBarrier compile on Win x64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11888016: Workaround to make MemoryBarrier compile on Win x64 (Closed)

Created:
7 years, 11 months ago by scottmg

Modified:
7 years, 11 months ago

Reviewers:
jschuh, brettw

CC:
chromium-reviews, erikwright+watch_chromium.org, jschuh

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Workaround to make MemoryBarrier compile on Win x64 windows.h #defines "MemoryBarrier" on x64 (on x86 it's an forceinline function). Because atomicops.h uses MemoryBarrier as the public api name, workaround by #undefing and then calling the implementation directly. ref: http://msdn.microsoft.com/en-us/library/windows/desktop/ms684208.aspx R=brettw@chromium.org BUG=166496 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176859

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -0 lines)			Patch
	M	base/atomicops.h	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
	M	base/atomicops_internals_x86_msvc.h	View	1	2 chunks	+14 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11888016/3001

7 years, 11 months ago (2013-01-15 00:56:11 UTC) #4

Message was sent while issue was closed.

Change committed as 176859