Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2495)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

Issue 11886074: Use correct favicon scale factor on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Split DeviceTelephonyInfo from DeviceDisplayInfo; added SCALE_FACTOR_150P and 300P. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/base/chrome_test_suite.cc » ('j') | ui/base/layout.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
index bbf1ad4f57c76e172f3600460c6c96ae95330dbc..415736a01f8feacaf3a8c65ff967be900f695b16 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
@@ -26,8 +26,8 @@ import org.chromium.content.browser.test.util.CallbackHelper;
import org.chromium.content.browser.test.util.Criteria;
import org.chromium.content.browser.test.util.CriteriaHelper;
import org.chromium.content.browser.test.util.HistoryUtils;
-import org.chromium.content.common.DeviceInfo;
import org.chromium.net.test.util.TestWebServer;
+import org.chromium.ui.gfx.DeviceDisplayInfo;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
@@ -2099,8 +2099,9 @@ public class AwSettingsTest extends AndroidWebViewTestBase {
pageTemplate,
"<meta name='viewport' content='width=" + viewportTagSpecifiedWidth + "' />");
- DeviceInfo deviceInfo = DeviceInfo.create(getInstrumentation().getTargetContext());
- int displayWidth = (int) (deviceInfo.getWidth() / deviceInfo.getDPIScale());
+ DeviceDisplayInfo deviceInfo =
+ DeviceDisplayInfo.create(getInstrumentation().getTargetContext());
+ int displayWidth = (int) (deviceInfo.getDisplayWidth() / deviceInfo.getDIPScale());
settings.setJavaScriptEnabled(true);
assertFalse(settings.getUseWideViewPort());
« no previous file with comments | « no previous file | chrome/test/base/chrome_test_suite.cc » ('j') | ui/base/layout.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698