Use correct favicon scale factor on Android.

android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
index bbf1ad4f57c76e172f3600460c6c96ae95330dbc..d53b9c2b749ce00a70cbbabae272627f44786e12 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
@@ -26,8 +26,8 @@ import org.chromium.content.browser.test.util.CallbackHelper;
 import org.chromium.content.browser.test.util.Criteria;
 import org.chromium.content.browser.test.util.CriteriaHelper;
 import org.chromium.content.browser.test.util.HistoryUtils;
-import org.chromium.content.common.DeviceInfo;
 import org.chromium.net.test.util.TestWebServer;
+import org.chromium.ui.gfx.DeviceInfo;
 
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
@@ -2100,7 +2100,7 @@ public class AwSettingsTest extends AndroidWebViewTestBase {
                 "<meta name='viewport' content='width=" + viewportTagSpecifiedWidth + "' />");
 
         DeviceInfo deviceInfo = DeviceInfo.create(getInstrumentation().getTargetContext());
-        int displayWidth = (int) (deviceInfo.getWidth() / deviceInfo.getDPIScale());
+        int displayWidth = (int) (deviceInfo.getDisplayWidth() / deviceInfo.getDIPScale());

[Nico, 2013/01/17 06:31:33]

Math.round()? You have real fractional DIP scaled on android, right?

[aruslan, 2013/01/17 23:01:10]

The code below seems to tolerate off-by-one rounding errors.
I leave it up to mnaganov@ to decide.

[mnaganov (inactive), 2013/01/18 00:39:51]

I think it's fine as it is.

1) When I was writing the original code, I have checked other parts that do
similar density-related calculations, and they were also using floor.

2) As aruslan@ says, we don't check for exact match, but rather tolerate
off-by-one errors.

 
         settings.setJavaScriptEnabled(true);
         assertFalse(settings.getUseWideViewPort());