Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 11886067: Added correct Mac mappings for the DragonRise Generic USB Gamepad. (Closed)

Created:
7 years, 11 months ago by sylvinus
Modified:
7 years, 11 months ago
Reviewers:
sylvain, scottmg
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, sail+watch_chromium.org
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Added correct Mac mappings for the DragonRise Generic USB Gamepad. BUG=167228 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177212

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gamepad/gamepad_standard_mappings_mac.mm View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
scottmg
Thanks! lgtm Before we can commit, you'll need to do the CLA. http://dev.chromium.org/developers/contributing-code Have you ...
7 years, 11 months ago (2013-01-16 16:50:51 UTC) #1
sylvain_sylvainzimmer.com
Ok, thanks! I did the electronic CLA earlier today. Cheers, -- Sylvain Zimmer blog: sylvinus.org ...
7 years, 11 months ago (2013-01-16 16:53:39 UTC) #2
scottmg
Oh, also, the name in AUTHORS has to match the address on this site. It ...
7 years, 11 months ago (2013-01-16 16:53:44 UTC) #3
sylvain_sylvainzimmer.com
No worries, just updated AUTHORS. I still feel like a fraud being there for such ...
7 years, 11 months ago (2013-01-16 16:58:32 UTC) #4
scottmg
Thanks. Sorry to belabour this further, but you used that same email address on the ...
7 years, 11 months ago (2013-01-16 17:06:43 UTC) #5
sylvain_sylvainzimmer.com
I did not :) Just submitted a new one. -- Sylvain Zimmer blog: sylvinus.org gsm: ...
7 years, 11 months ago (2013-01-16 17:17:15 UTC) #6
scottmg
On 2013/01/16 17:17:15, sylvain_sylvainzimmer.com wrote: > I did not :) Just submitted a new one. ...
7 years, 11 months ago (2013-01-16 17:24:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sylvinus@gmail.com/11886067/4001
7 years, 11 months ago (2013-01-16 17:25:01 UTC) #8
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 20:43:34 UTC) #9
Message was sent while issue was closed.
Change committed as 177212

Powered by Google App Engine
This is Rietveld 408576698