sql/statement.cc - Issue 11886065: Fixing null pointer dereference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sql/statement.cc

Issue 11886065: Fixing null pointer dereference. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sql/statement.cc

diff --git a/sql/statement.cc b/sql/statement.cc

index 84dfd2eb9aa850407cff6e84c83e49cce646d865..cd55bf710ff94ca4d3ea1def37f3ebed41815a3a 100644

--- a/sql/statement.cc

+++ b/sql/statement.cc

@@ -306,7 +306,7 @@ bool Statement::CheckOk(int err) const {

int Statement::CheckError(int err) {

// Please don't add DCHECKs here, OnSqliteError() already has them.

succeeded_ = (err == SQLITE_OK || err == SQLITE_ROW || err == SQLITE_DONE);

- if (!succeeded_ && is_valid())

+ if (!succeeded_ && is_valid() && ref_->connection())

return ref_->connection()->OnSqliteError(err, this);

return err;

}

« no previous file with comments | « sql/connection.h ('k') | no next file » | no next file with comments »