Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 11886043: Add magnifier_controller unittest (Closed)

Created:
7 years, 11 months ago by yoshiki
Modified:
7 years, 11 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Add magnifier_controller unittest BUG=none TEST=ash_unittests passes R=zork@chromium.org TBR=derat@chromium.org # TBRing for modifying only magnifier related code. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177145

Patch Set 1 #

Patch Set 2 : minor changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -0 lines) Patch
M ash/ash.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A ash/magnifier/magnification_controller_unittest.cc View 1 1 chunk +157 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yoshiki
@zork: could you take a look? Thanks,
7 years, 11 months ago (2013-01-16 04:52:16 UTC) #1
Zachary Kuznia
lgtm
7 years, 11 months ago (2013-01-16 05:03:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11886043/12001
7 years, 11 months ago (2013-01-16 05:04:34 UTC) #3
commit-bot: I haz the power
Presubmit check for 11886043-12001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-16 05:04:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11886043/12001
7 years, 11 months ago (2013-01-16 11:16:41 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 13:31:24 UTC) #6
Message was sent while issue was closed.
Change committed as 177145

Powered by Google App Engine
This is Rietveld 408576698