Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 11886005: Fix GpuChannelHost destruction races. (Closed)

Created:
7 years, 11 months ago by piman
Modified:
7 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Fix GpuChannelHost destruction races. GpuChannelHost::MessageFilter can outlive GpuChannelHost, so make sure it doesn't use a raw pointer to it. Also ensure the BrowserGpuChannelHostFactory outlives the IO thread. BUG=168282 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176557

Patch Set 1 #

Patch Set 2 : re-enable tests #

Patch Set 3 : stupid ios #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -21 lines) Patch
M chrome/test/gpu/gpu_feature_browsertest.cc View 1 2 chunks +2 lines, -8 lines 2 comments Download
M content/browser/browser_main_loop.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 3 chunks +10 lines, -3 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 6 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
piman
7 years, 11 months ago (2013-01-11 23:27:53 UTC) #1
Ken Russell (switch to Gerrit)
LGTM
7 years, 11 months ago (2013-01-11 23:35:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/11886005/7001
7 years, 11 months ago (2013-01-11 23:56:03 UTC) #3
ncarter (slow)
https://codereview.chromium.org/11886005/diff/7001/chrome/test/gpu/gpu_feature_browsertest.cc File chrome/test/gpu/gpu_feature_browsertest.cc (right): https://codereview.chromium.org/11886005/diff/7001/chrome/test/gpu/gpu_feature_browsertest.cc#newcode264 chrome/test/gpu/gpu_feature_browsertest.cc:264: IN_PROC_BROWSER_TEST_F(GpuFeatureTest, MAYBE_WebGLAllowed) { Should fix this too. https://codereview.chromium.org/11886005/diff/7001/chrome/test/gpu/gpu_feature_browsertest.cc#newcode279 chrome/test/gpu/gpu_feature_browsertest.cc:279: ...
7 years, 11 months ago (2013-01-12 00:11:08 UTC) #4
piman
On Fri, Jan 11, 2013 at 4:11 PM, <nick@chromium.org> wrote: > > https://codereview.chromium.**org/11886005/diff/7001/chrome/** > test/gpu/gpu_feature_**browsertest.cc<https://codereview.chromium.org/11886005/diff/7001/chrome/test/gpu/gpu_feature_browsertest.cc> ...
7 years, 11 months ago (2013-01-12 00:14:34 UTC) #5
ncarter (slow)
On 2013/01/12 00:14:34, piman wrote: > On Fri, Jan 11, 2013 at 4:11 PM, <mailto:nick@chromium.org> ...
7 years, 11 months ago (2013-01-12 00:17:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/11886005/7001
7 years, 11 months ago (2013-01-12 04:05:20 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-12 17:16:28 UTC) #8
Message was sent while issue was closed.
Change committed as 176557

Powered by Google App Engine
This is Rietveld 408576698