Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11885025: Allow re-targeting of naclports install (Closed)

Created:
7 years, 11 months ago by Sam Clegg
Modified:
7 years, 11 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Allow re-targeting of naclports install. This allows users to define NACLPORTS_PREFIX in order to have naclports build into a custom location rather than directly into the toolchain dir. This change renames: NACL_SDK_USR NACL_SDK_USR_INCLUDE NACL_SDK_USR_LIB to: NACLPORTS_PREFIX NACLPORTS_INCLUDE NACLPORTS_LIBDIR BUG=None Committed: https://code.google.com/p/naclports/source/detail?r=657

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -268 lines) Patch
M Makefile View 1 chunk +7 lines, -6 lines 0 comments Download
M build_tools/common.sh View 1 2 6 chunks +26 lines, -22 lines 0 comments Download
M examples/audio/openal-ogg/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M examples/audio/openal-ogg/nacl-openal-ogg.sh View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M examples/games/nethack-3.4.3/nacl-nethack-3.4.3.patch View 1 chunk +1 line, -1 line 0 comments Download
M examples/games/nethack-3.4.3/nacl-nethack-3.4.3.sh View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M examples/games/scummvm-1.2.1/nacl-scummvm-1.2.1.sh View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M examples/games/snes9x-1.53/nacl-snes9x-1.53.sh View 1 2 2 chunks +11 lines, -11 lines 0 comments Download
M examples/graphics/xaos/nacl-xaos.sh View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M examples/needs_porting/xaos/xaos_tool.sh View 1 chunk +1 line, -1 line 0 comments Download
M examples/systems/bochs-2.4.6/nacl-bochs-2.4.6.sh View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M examples/systems/dosbox-0.74/nacl-dosbox-0.74.sh View 1 2 1 chunk +13 lines, -13 lines 0 comments Download
M examples/tools/thttpd-2.25b/nacl-thttpd-2.25b.sh View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M libraries/FreeImage-3.14.1/nacl-FreeImage-3.14.1.patch View 1 chunk +2 lines, -2 lines 0 comments Download
M libraries/FreeImage-3.14.1/nacl-FreeImage-3.14.1.sh View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M libraries/ImageMagick-6.5.4-10/nacl-ImageMagick-6.5.4-10.sh View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M libraries/Mesa-7.6/nacl-Mesa-7.6.sh View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M libraries/OpenSceneGraph-2.9.7/nacl-OpenSceneGraph-2.9.7.patch View 4 chunks +10 lines, -10 lines 0 comments Download
M libraries/OpenSceneGraph-2.9.7/nacl-OpenSceneGraph-2.9.7.sh View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M libraries/SDL-1.2.14/nacl-SDL-1.2.14.sh View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M libraries/SDL_mixer-1.2.11/nacl-SDL_mixer-1.2.11.sh View 1 2 3 chunks +8 lines, -7 lines 0 comments Download
M libraries/agg-2.5/nacl-agg-2.5.sh View 1 2 1 chunk +6 lines, -7 lines 0 comments Download
M libraries/boost_1_47_0/nacl-boost_1_47_0.sh View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M libraries/bzip2-1.0.6/nacl-bzip2-1.0.6.sh View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M libraries/dreadthread/nacl-dreadthread.sh View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M libraries/faac-1.28/nacl-faac-1.28.sh View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M libraries/ffmpeg-0.5/nacl-ffmpeg-0.5.sh View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M libraries/fftw-3.2.2/nacl-fftw-3.2.2.sh View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M libraries/flac-1.2.1/nacl-flac-1.2.1.sh View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M libraries/fontconfig-2.7.3/nacl-fontconfig-2.7.3.sh View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M libraries/freetype-2.1.10/nacl-freetype-2.1.10.sh View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M libraries/gc6.8/nacl-gc6.8.sh View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M libraries/glib-2.28.8/nacl-glib-2.28.8.sh View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M libraries/glibc-compat/nacl-glibc-compat.sh View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M libraries/gmock-1.5.0/nacl-gmock-1.5.0.sh View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M libraries/gtest-1.5.0/nacl-gtest-1.5.0.sh View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M libraries/jsoncpp-0.5.0/nacl-jsoncpp-0.5.0.sh View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M libraries/libtheora-1.1.1/nacl-libtheora-1.1.1.sh View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M libraries/libtomcrypt-1.17/nacl-libtomcrypt-1.17.sh View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M libraries/libtommath-0.41/nacl-libtommath-0.41.sh View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M libraries/lua-5.1.4/nacl-lua-5.1.4.sh View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M libraries/nacl-mounts/nacl-nacl-mounts.sh View 1 2 2 chunks +13 lines, -19 lines 0 comments Download
M libraries/openal-soft-1.13/nacl-openal-soft-1.13.sh View 1 2 1 chunk +1 line, -1 line 0 comments Download
M libraries/openssl-1.0.0e/nacl-openssl-1.0.0e.sh View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M libraries/pango-1.29.3/nacl-pango-1.29.3.sh View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M libraries/pixman-0.16.2/nacl-pixman-0.16.2.sh View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M libraries/tinyxml/nacl-tinyxml.sh View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M libraries/x264-snapshot-20091023-2245/nacl-x264-snapshot-20091023-2245.sh View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M libraries/zlib-1.2.3/nacl-zlib-1.2.3.sh View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Sam Clegg
7 years, 11 months ago (2013-01-14 21:56:36 UTC) #1
bradn
7 years, 11 months ago (2013-01-14 22:20:00 UTC) #2 
Otherwise LGTM

https://codereview.chromium.org/11885025/diff/1/examples/games/nethack-3.4.3/...
File examples/games/nethack-3.4.3/nacl-nethack-3.4.3.sh (right):

https://codereview.chromium.org/11885025/diff/1/examples/games/nethack-3.4.3/...
examples/games/nethack-3.4.3/nacl-nethack-3.4.3.sh:32: export
NACL_LDFLAGS="${NACLPORT_LDFLAGS}"
NACLPORTS ?

Powered by Google App Engine
This is Rietveld 408576698