Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4673)

Unified Diff: chrome/browser/ui/webui/session_favicon_source.cc

Issue 11885021: Don't derive from ChromeURLDataManager::DataSource, and instead have these classes implement a dele… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: nits Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/session_favicon_source.cc
===================================================================
--- chrome/browser/ui/webui/session_favicon_source.cc (revision 176443)
+++ chrome/browser/ui/webui/session_favicon_source.cc (working copy)
@@ -7,19 +7,22 @@
#include "chrome/browser/sync/glue/session_model_associator.h"
#include "chrome/browser/sync/profile_sync_service_factory.h"
#include "chrome/browser/sync/profile_sync_service.h"
+#include "chrome/browser/ui/webui/chrome_url_data_manager.h"
#include "chrome/common/url_constants.h"
using browser_sync::SessionModelAssociator;
SessionFaviconSource::SessionFaviconSource(Profile* profile)
- : FaviconSource(profile,
- FaviconSource::FAVICON,
- chrome::kChromeUISessionFaviconHost) {
+ : FaviconSource(profile, FaviconSource::FAVICON) {
}
SessionFaviconSource::~SessionFaviconSource() {
}
+std::string SessionFaviconSource::GetSource() {
+ return chrome::kChromeUISessionFaviconHost;
+}
+
std::string SessionFaviconSource::GetMimeType(const std::string&) const {
return "image/png";
}
@@ -49,7 +52,7 @@
scoped_refptr<base::RefCountedString> response =
new base::RefCountedString();
response->data() = favicon_data;
- SendResponse(request.request_id, response);
+ url_data_source()->SendResponse(request.request_id, response);
return true;
}
return false;

Powered by Google App Engine
This is Rietveld 408576698