Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: chrome/browser/ui/webui/options/chromeos/user_image_source.cc

Issue 11885021: Don't derive from ChromeURLDataManager::DataSource, and instead have these classes implement a dele… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: nits Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/chromeos/user_image_source.cc
===================================================================
--- chrome/browser/ui/webui/options/chromeos/user_image_source.cc (revision 176443)
+++ chrome/browser/ui/webui/options/chromeos/user_image_source.cc (working copy)
@@ -9,6 +9,7 @@
#include "base/string_split.h"
#include "chrome/browser/chromeos/login/default_user_images.h"
#include "chrome/browser/chromeos/login/user_manager.h"
+#include "chrome/browser/ui/webui/chrome_url_data_manager.h"
#include "chrome/browser/ui/webui/web_ui_util.h"
#include "chrome/common/url_constants.h"
#include "googleurl/src/url_parse.h"
@@ -76,12 +77,15 @@
LoadDataResourceBytesForScale(IDR_LOGIN_DEFAULT_USER, scale_factor);
}
-UserImageSource::UserImageSource()
- : DataSource(chrome::kChromeUIUserImageHost, MessageLoop::current()) {
+UserImageSource::UserImageSource() {
}
UserImageSource::~UserImageSource() {}
+std::string UserImageSource::GetSource() {
+ return chrome::kChromeUIUserImageHost;
+}
+
void UserImageSource::StartDataRequest(const std::string& path,
bool is_incognito,
int request_id) {
@@ -90,8 +94,9 @@
ui::ScaleFactor scale_factor;
GURL url(chrome::kChromeUIUserImageURL + path);
ParseRequest(url, &email, &is_image_animated, &scale_factor);
- SendResponse(request_id,
- GetUserImage(email, is_image_animated, scale_factor));
+ url_data_source()->SendResponse(
+ request_id,
+ GetUserImage(email, is_image_animated, scale_factor));
}
std::string UserImageSource::GetMimeType(const std::string& path) const {

Powered by Google App Engine
This is Rietveld 408576698