Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: chrome/browser/ui/webui/extensions/extension_icon_source.h

Issue 11885021: Don't derive from ChromeURLDataManager::DataSource, and instead have these classes implement a dele… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: nits Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_icon_source.h
===================================================================
--- chrome/browser/ui/webui/extensions/extension_icon_source.h (revision 176443)
+++ chrome/browser/ui/webui/extensions/extension_icon_source.h (working copy)
@@ -9,11 +9,12 @@
#include <string>
#include "base/basictypes.h"
+#include "base/memory/weak_ptr.h"
#include "chrome/browser/favicon/favicon_service.h"
-#include "chrome/browser/ui/webui/chrome_url_data_manager.h"
#include "chrome/common/cancelable_task_tracker.h"
#include "chrome/common/extensions/extension_icon_set.h"
#include "chrome/common/extensions/extension_resource.h"
+#include "content/public/browser/url_data_source_delegate.h"
#include "third_party/skia/include/core/SkBitmap.h"
class ExtensionIconSet;
@@ -49,7 +50,8 @@
// 2) If a 16px icon was requested, the favicon for extension's launch URL.
// 3) The default extension / application icon if there are still no matches.
//
-class ExtensionIconSource : public ChromeURLDataManager::DataSource {
+class ExtensionIconSource : public content::URLDataSourceDelegate,
+ public base::SupportsWeakPtr<ExtensionIconSource> {
public:
explicit ExtensionIconSource(Profile* profile);
@@ -68,10 +70,9 @@
// by |resource_id|.
static SkBitmap* LoadImageByResourceId(int resource_id);
- // ChromeURLDataManager::DataSource
-
+ // content::URLDataSourceDelegate implementation.
+ virtual std::string GetSource() OVERRIDE;
virtual std::string GetMimeType(const std::string&) const OVERRIDE;
-
virtual void StartDataRequest(const std::string& path,
bool is_incognito,
int request_id) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698