Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7309)

Unified Diff: chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc

Issue 11885021: Don't derive from ChromeURLDataManager::DataSource, and instead have these classes implement a dele… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: nits Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc
===================================================================
--- chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc (revision 176443)
+++ chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc (working copy)
@@ -32,6 +32,7 @@
#include "chrome/common/url_constants.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/render_view_host_observer.h"
+#include "content/public/browser/url_data_source_delegate.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_ui.h"
#include "content/public/browser/web_ui_message_handler.h"
@@ -113,12 +114,12 @@
DISALLOW_COPY_AND_ASSIGN(PortalFrameLoadObserver);
};
-class MobileSetupUIHTMLSource : public ChromeURLDataManager::DataSource {
+class MobileSetupUIHTMLSource : public content::URLDataSourceDelegate {
public:
MobileSetupUIHTMLSource();
- // Called when the network layer has requested a resource underneath
- // the path we registered.
+ // content::URLDataSourceDelegate implementation.
+ virtual std::string GetSource() OVERRIDE;
virtual void StartDataRequest(const std::string& path,
bool is_incognito,
int request_id);
@@ -171,10 +172,13 @@
//
////////////////////////////////////////////////////////////////////////////////
-MobileSetupUIHTMLSource::MobileSetupUIHTMLSource()
- : DataSource(chrome::kChromeUIMobileSetupHost, MessageLoop::current()) {
+MobileSetupUIHTMLSource::MobileSetupUIHTMLSource() {
}
+std::string MobileSetupUIHTMLSource::GetSource() OVERRIDE {
+ return chrome::kChromeUIMobileSetupHost;
+}
+
void MobileSetupUIHTMLSource::StartDataRequest(const std::string& path,
bool is_incognito,
int request_id) {
@@ -184,7 +188,7 @@
if (!network || !network->SupportsActivation()) {
LOG(WARNING) << "Can't find device to activate for service path " << path;
scoped_refptr<base::RefCountedBytes> html_bytes(new base::RefCountedBytes);
- SendResponse(request_id, html_bytes);
+ url_data_source()->SendResponse(request_id, html_bytes);
return;
}
@@ -210,7 +214,7 @@
l10n_util::GetStringUTF16(IDS_CANCEL));
strings.SetString("ok_button",
l10n_util::GetStringUTF16(IDS_OK));
- SetFontAndTextDirection(&strings);
+ URLDataSource::SetFontAndTextDirection(&strings);
static const base::StringPiece html(
ResourceBundle::GetSharedInstance().GetRawDataResource(
@@ -219,7 +223,8 @@
std::string full_html = jstemplate_builder::GetI18nTemplateHtml(html,
&strings);
- SendResponse(request_id, base::RefCountedString::TakeString(&full_html));
+ url_data_source()->SendResponse(
+ request_id, base::RefCountedString::TakeString(&full_html));
}
////////////////////////////////////////////////////////////////////////////////

Powered by Google App Engine
This is Rietveld 408576698