Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1385)

Unified Diff: chrome/browser/ui/webui/about_ui.h

Issue 11885021: Don't derive from ChromeURLDataManager::DataSource, and instead have these classes implement a dele… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: nits Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/about_ui.h
===================================================================
--- chrome/browser/ui/webui/about_ui.h (revision 176443)
+++ chrome/browser/ui/webui/about_ui.h (working copy)
@@ -8,24 +8,26 @@
#include <string>
#include "base/basictypes.h"
-#include "chrome/browser/ui/webui/chrome_url_data_manager.h"
+#include "base/compiler_specific.h"
+#include "base/memory/weak_ptr.h"
+#include "content/public/browser/url_data_source_delegate.h"
#include "content/public/browser/web_ui_controller.h"
class Profile;
// We expose this class because the OOBE flow may need to explicitly add the
// chrome://terms source outside of the normal flow.
-class AboutUIHTMLSource : public ChromeURLDataManager::DataSource {
+class AboutUIHTMLSource : public content::URLDataSourceDelegate,
+ public base::SupportsWeakPtr<AboutUIHTMLSource> {
public:
// Construct a data source for the specified |source_name|.
AboutUIHTMLSource(const std::string& source_name, Profile* profile);
- // Called when the network layer has requested a resource underneath
- // the path we registered.
+ // content::URLDataSourceDelegate implementation.
+ virtual std::string GetSource() OVERRIDE;
virtual void StartDataRequest(const std::string& path,
bool is_incognito,
int request_id) OVERRIDE;
-
virtual std::string GetMimeType(const std::string& path) const OVERRIDE;
// Send the response data.
@@ -36,6 +38,7 @@
private:
virtual ~AboutUIHTMLSource();
+ std::string source_name_;
Profile* profile_;
DISALLOW_COPY_AND_ASSIGN(AboutUIHTMLSource);

Powered by Google App Engine
This is Rietveld 408576698