Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc

Issue 11885021: Don't derive from ChromeURLDataManager::DataSource, and instead have these classes implement a dele… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: nits Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/ntp/ntp_resource_cache.h" 5 #include "chrome/browser/ui/webui/ntp/ntp_resource_cache.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/memory/ref_counted_memory.h" 8 #include "base/memory/ref_counted_memory.h"
9 #include "base/string16.h" 9 #include "base/string16.h"
10 #include "base/string_piece.h" 10 #include "base/string_piece.h"
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 l10n_util::GetStringUTF16(IDS_BOOKMARK_REMOVE_FOLDER)); 95 l10n_util::GetStringUTF16(IDS_BOOKMARK_REMOVE_FOLDER));
96 localized_strings.SetString("receivedDocuments", 96 localized_strings.SetString("receivedDocuments",
97 l10n_util::GetStringUTF16(IDS_RECEIVED_DOCUMENTS)); 97 l10n_util::GetStringUTF16(IDS_RECEIVED_DOCUMENTS));
98 localized_strings.SetString("syncPromo", 98 localized_strings.SetString("syncPromo",
99 l10n_util::GetStringUTF16(IDS_SYNC_PROMO_DESKTOP_INSTRUCTIONS)); 99 l10n_util::GetStringUTF16(IDS_SYNC_PROMO_DESKTOP_INSTRUCTIONS));
100 localized_strings.SetString("syncEnableSync", 100 localized_strings.SetString("syncEnableSync",
101 l10n_util::GetStringUTF16(IDS_SYNC_ENABLE_SYNC)); 101 l10n_util::GetStringUTF16(IDS_SYNC_ENABLE_SYNC));
102 localized_strings.SetString("bookmarkstitle", 102 localized_strings.SetString("bookmarkstitle",
103 l10n_util::GetStringUTF16(IDS_ACCNAME_BOOKMARKS)); 103 l10n_util::GetStringUTF16(IDS_ACCNAME_BOOKMARKS));
104 104
105 ChromeURLDataManager::DataSource::SetFontAndTextDirection(&localized_strings); 105 URLDataSource::SetFontAndTextDirection(&localized_strings);
106 106
107 base::StringPiece new_tab_html(ResourceBundle::GetSharedInstance(). 107 base::StringPiece new_tab_html(ResourceBundle::GetSharedInstance().
108 GetRawDataResource(IDR_NEW_TAB_ANDROID_HTML)); 108 GetRawDataResource(IDR_NEW_TAB_ANDROID_HTML));
109 localized_strings.SetString( 109 localized_strings.SetString(
110 "device", 110 "device",
111 CommandLine::ForCurrentProcess()->HasSwitch(switches::kTabletUI) ? 111 CommandLine::ForCurrentProcess()->HasSwitch(switches::kTabletUI) ?
112 "tablet" : "phone"); 112 "tablet" : "phone");
113 const char* new_tab_link = kLearnMoreIncognitoUrl; 113 const char* new_tab_link = kLearnMoreIncognitoUrl;
114 string16 learnMoreLink = ASCIIToUTF16( 114 string16 learnMoreLink = ASCIIToUTF16(
115 google_util::AppendGoogleLocaleParam(GURL(new_tab_link)).spec()); 115 google_util::AppendGoogleLocaleParam(GURL(new_tab_link)).spec());
(...skipping 19 matching lines...) Expand all
135 size_t after_offset = pos + template_data_placeholder.size(); 135 size_t after_offset = pos + template_data_placeholder.size();
136 full_html.append(new_tab_html.data() + after_offset, 136 full_html.append(new_tab_html.data() + after_offset,
137 new_tab_html.size() - after_offset); 137 new_tab_html.size() - after_offset);
138 } else { 138 } else {
139 NOTREACHED(); 139 NOTREACHED();
140 full_html.assign(new_tab_html.data(), new_tab_html.size()); 140 full_html.assign(new_tab_html.data(), new_tab_html.size());
141 } 141 }
142 142
143 new_tab_html_ = base::RefCountedString::TakeString(&full_html); 143 new_tab_html_ = base::RefCountedString::TakeString(&full_html);
144 } 144 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698