Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1277)

Unified Diff: chrome/browser/android/crash_dump_manager.h

Issue 11884042: Fix for a crasher when starting a renderer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Synced Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/crash_dump_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/crash_dump_manager.h
diff --git a/chrome/browser/android/crash_dump_manager.h b/chrome/browser/android/crash_dump_manager.h
index cafe26be9d4a544a0ad0211e6f83798c307c3e2a..95876146d2733a03a4a6f695589b0a9b080fc6b6 100644
--- a/chrome/browser/android/crash_dump_manager.h
+++ b/chrome/browser/android/crash_dump_manager.h
@@ -29,8 +29,10 @@ class RenderProcessHost;
// processes and take the appropriate action when the render process terminates.
class CrashDumpManager : public content::NotificationObserver {
public:
- // Should be created on the UI thread.
- CrashDumpManager();
+ // This object is a singleton created and owned by the
+ // ChromeBrowserMainPartsAndroid.
+ static CrashDumpManager* GetInstance();
+
virtual ~CrashDumpManager();
// Returns a file descriptor that should be used to generate a minidump for
@@ -38,6 +40,11 @@ class CrashDumpManager : public content::NotificationObserver {
int CreateMinidumpFile(int child_process_id);
private:
+ friend class ChromeBrowserMainPartsAndroid;
+
+ // Should be created on the UI thread.
+ CrashDumpManager();
+
typedef std::map<int, FilePath> ChildProcessIDToMinidumpPath;
static void ProcessMinidump(const FilePath& minidump_path,
@@ -55,6 +62,8 @@ class CrashDumpManager : public content::NotificationObserver {
base::Lock child_process_id_to_minidump_path_lock_;
ChildProcessIDToMinidumpPath child_process_id_to_minidump_path_;
+ static CrashDumpManager* instance_;
+
DISALLOW_COPY_AND_ASSIGN(CrashDumpManager);
};
« no previous file with comments | « no previous file | chrome/browser/android/crash_dump_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698