Fix for a crasher when starting a renderer.

Fix for a crasher when starting a renderer.

A crash dump from the field reports that the CrashDumpManager in
ChromeContentBrowserClient is not initialized when
GetAdditionalMappedFilesForChildProcess is called.
This is because the CrashDumpManager is initialized when a RenderProcessHost
is created, but it could be the case that a BrowserChildProcessHost gets
created first and calls GetAdditionalMappedFilesForChildProcess before
any RenderProcessHost was created.
Making the CrashDumpManager a singleton initialized early on to prevent this
crasher.

BUG=163456
TEST=None


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177110

[Jay Civelli, 2013-01-15 02:23:47]

Per our discussion, made the CrashDumpManager a singleton owned by the
ChromeBrowserMainAndroid.

[jam, 2013-01-15 20:36:26]

lgtm

https://codereview.chromium.org/11884042/diff/2001/chrome/browser/android/cra...
File chrome/browser/android/crash_dump_manager.cc (right):

https://codereview.chromium.org/11884042/diff/2001/chrome/browser/android/cra...
chrome/browser/android/crash_dump_manager.cc:56:
CrashDumpManager::~CrashDumpManager() {
nit: reset here?

[commit-bot: I haz the power, 2013-01-16 00:08:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jcivelli@chromium.org/11884042/13001

[commit-bot: I haz the power, 2013-01-16 00:08:09]

Failed to apply patch for chrome/browser/chrome_browser_main_android.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/chrome_browser_main_android.cc
  Hunk #1 FAILED at 6.
  Hunk #2 succeeded at 36 (offset 1 line).
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/chrome_browser_main_android.cc.rej

Patch:       chrome/browser/chrome_browser_main_android.cc
Index: chrome/browser/chrome_browser_main_android.cc
diff --git a/chrome/browser/chrome_browser_main_android.cc
b/chrome/browser/chrome_browser_main_android.cc
index
354a92de3b2b1341d6fc3048dd08e901e2b7b23f..6fc1d2e3088739ebb3cbbed6ac8ed534b187a508
100644
--- a/chrome/browser/chrome_browser_main_android.cc
+++ b/chrome/browser/chrome_browser_main_android.cc
@@ -6,6 +6,7 @@
 
 #include "base/path_service.h"
 #include "chrome/app/breakpad_linux.h"
+#include "chrome/browser/android/crash_dump_manager.h"
 #include "content/public/browser/android/compositor.h"
 #include "content/public/common/main_function_params.h"
 #include "net/android/network_change_notifier_factory_android.h"
@@ -35,8 +36,10 @@ void ChromeBrowserMainPartsAndroid::PreProfileInit() {
   if (!breakpad_enabled)
     breakpad_enabled = getenv(env_vars::kEnableBreakpad) != NULL;
 
-  if (breakpad_enabled)
+  if (breakpad_enabled) {
     InitCrashReporter();
+    crash_dump_manager_.reset(new CrashDumpManager());
+  }
 #endif
 
   ChromeBrowserMainParts::PreProfileInit();

[commit-bot: I haz the power, 2013-01-16 02:09:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jcivelli@chromium.org/11884042/17001

[commit-bot: I haz the power, 2013-01-16 04:29:49]

Retried try job too often on win for step(s) compile

[commit-bot: I haz the power, 2013-01-16 04:55:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jcivelli@chromium.org/11884042/17001

[commit-bot: I haz the power, 2013-01-16 09:02:53]

Change committed as 177110