Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3681)

Unified Diff: chrome/browser/search_engines/template_url.h

Issue 11884037: InstantExtended: Bail on TemplateURLs with no espv. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix browsertest. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/instant/instant_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search_engines/template_url.h
diff --git a/chrome/browser/search_engines/template_url.h b/chrome/browser/search_engines/template_url.h
index 9660347e8af2abcf197751d06a17b1e45b839000..d2d2c4863f1958dd317ea0974b21bf9bab460109 100644
--- a/chrome/browser/search_engines/template_url.h
+++ b/chrome/browser/search_engines/template_url.h
@@ -431,6 +431,7 @@ class TemplateURL {
const std::string& sync_guid() const { return data_.sync_guid; }
+ // TODO(beaudoin): Rename this when renaming HasSearchTermsReplacementKey().
const std::string& search_terms_replacement_key() const {
return data_.search_terms_replacement_key;
}
@@ -486,6 +487,8 @@ class TemplateURL {
// key in either the query or the ref. This method does not verify anything
// else about the URL. In particular, it does not check that the domain
// matches that of this TemplateURL.
+ // TODO(beaudoin): Rename this to reflect that it really checks for an
+ // InstantExtended capable URL.
bool HasSearchTermsReplacementKey(const GURL& url) const;
private:
« no previous file with comments | « chrome/browser/instant/instant_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698