Separated BluetoothServiceRecord interface from BluetoothServiceRecordChromeOs.

device/bluetooth/bluetooth_service_record.h

Index: device/bluetooth/bluetooth_service_record.h
diff --git a/device/bluetooth/bluetooth_service_record.h b/device/bluetooth/bluetooth_service_record.h
index e04d73a632f86fa4be5bcbbc9f494f7ae2bf03f4..0ed5cd05c72563e21aebd475f2f825999527f56d 100644
--- a/device/bluetooth/bluetooth_service_record.h
+++ b/device/bluetooth/bluetooth_service_record.h
@@ -9,8 +9,6 @@
 
 #include "base/basictypes.h"
 
-class XmlReader;
-
 namespace device {
 
 // BluetoothServiceRecord represents an SDP service record.
@@ -19,9 +17,7 @@ namespace device {
 // that have been necessary so far.
 class BluetoothServiceRecord {
  public:

[bryeung, 2013/01/14 20:21:46]

missing the no-argument constructor

[youngki, 2013/01/14 20:37:57]

I put the constructor under protected access specifier to enforce that this
class shouldn't be instantiated directly.

[bryeung, 2013/01/14 20:40:55]

Oops!  Missed that.

-   BluetoothServiceRecord(
-       const std::string& address,
-       const std::string& xml_data);
+   virtual ~BluetoothServiceRecord();

[bryeung, 2013/01/14 20:21:46]

The whitespace is messed up here (it was before too): these should all be
indented 2 spaces I think (not 3).

[youngki, 2013/01/14 20:37:57]

Hm.. it is messed up indeed..; fixed it.

 
    // The human-readable name of this service.
    const std::string& name() const { return name_; }
@@ -40,18 +36,18 @@ class BluetoothServiceRecord {
    // The return value is undefined if SupportsRfcomm() returns false.
    uint8 rfcomm_channel() const { return rfcomm_channel_; }
 
- private:
-  void ExtractChannels(XmlReader* reader);
-  void ExtractUuid(XmlReader* reader);
+ protected:
+   BluetoothServiceRecord();
 
-  std::string address_;
-  std::string name_;
-  std::string uuid_;
+   std::string address_;
+   std::string name_;
+   std::string uuid_;
 
-  bool supports_rfcomm_;
-  uint8 rfcomm_channel_;
+   bool supports_rfcomm_;
+   uint8 rfcomm_channel_;
 
-  DISALLOW_COPY_AND_ASSIGN(BluetoothServiceRecord);
+ private:
+   DISALLOW_COPY_AND_ASSIGN(BluetoothServiceRecord);
 };
 
 }  // namespace device