Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 11883038: Move is_incognito bit out of ChromeURLRequestContext (Closed)

Created:
7 years, 11 months ago by pauljensen
Modified:
7 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

Move is_incognito bit from ChromeURLRequestContext to ChromeURLDataManagerBackend's ProtocolHandlers. BUG=122969 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177270

Patch Set 1 : #

Total comments: 1

Patch Set 2 : sync to r177196 #

Patch Set 3 : Remove unneeded include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -37 lines) Patch
M chrome/browser/net/chrome_url_request_context.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_backend.h View 1 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_backend.cc View 1 2 15 chunks +43 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pauljensen
In the spirit of moving URLRequestContext members into URLRequestJobFactories/ProtocolHandlers I figured it would be good ...
7 years, 11 months ago (2013-01-15 21:20:20 UTC) #1
erikwright (departed)
LGTM. If there is other stuff that can be removed at this time (i.e., removing ...
7 years, 11 months ago (2013-01-15 21:25:32 UTC) #2
pauljensen
Matt, PTAL.
7 years, 11 months ago (2013-01-15 21:32:17 UTC) #3
mmenke
LGTM https://codereview.chromium.org/11883038/diff/11001/chrome/browser/ui/webui/chrome_url_data_manager_backend.cc File chrome/browser/ui/webui/chrome_url_data_manager_backend.cc (right): https://codereview.chromium.org/11883038/diff/11001/chrome/browser/ui/webui/chrome_url_data_manager_backend.cc#newcode22 chrome/browser/ui/webui/chrome_url_data_manager_backend.cc:22: #include "chrome/browser/net/chrome_url_request_context.h" Don't think this is needed any ...
7 years, 11 months ago (2013-01-16 16:51:26 UTC) #4
pauljensen
James, could you please review chrome/browser/ui/webui/?
7 years, 11 months ago (2013-01-16 20:07:05 UTC) #5
James Hawkins
lgtm
7 years, 11 months ago (2013-01-16 20:27:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pauljensen@chromium.org/11883038/21001
7 years, 11 months ago (2013-01-16 20:36:00 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 23:46:57 UTC) #8
Message was sent while issue was closed.
Change committed as 177270

Powered by Google App Engine
This is Rietveld 408576698