Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11883026: Add two new debug URLs for Pepper Flash: (Closed)

Created:
7 years, 11 months ago by yzshen1
Modified:
7 years, 11 months ago
Reviewers:
jschuh, brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add two new debug URLs for Pepper Flash: - chrome://ppapiflashcrash - chrome://ppapiflashhang TEST=none BUG=169915 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177983

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -1 line) Patch
M chrome/common/url_constants.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.h View 1 2 chunks +7 lines, -1 line 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M content/browser/web_contents/debug_urls.cc View 1 2 2 chunks +34 lines, -0 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M content/public/common/url_constants.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/url_constants.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
yzshen1
Hi, Brett and Justin. Would you please take a look? Thanks! Justin: ppapi_messages.h Brett: everything ...
7 years, 11 months ago (2013-01-15 01:01:51 UTC) #1
jschuh
ipc security lgtm.
7 years, 11 months ago (2013-01-15 15:13:58 UTC) #2
brettw
lgtm
7 years, 11 months ago (2013-01-18 18:25:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/11883026/5001
7 years, 11 months ago (2013-01-18 18:27:32 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-18 18:53:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/11883026/5001
7 years, 11 months ago (2013-01-18 22:28:47 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-18 22:44:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/11883026/5001
7 years, 11 months ago (2013-01-19 01:12:12 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-19 01:29:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/11883026/5001
7 years, 11 months ago (2013-01-19 05:41:43 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-19 05:59:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/11883026/5001
7 years, 11 months ago (2013-01-19 17:33:23 UTC) #12
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-19 17:48:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/11883026/5001
7 years, 11 months ago (2013-01-22 05:15:09 UTC) #14
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-22 05:28:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/11883026/27001
7 years, 11 months ago (2013-01-22 05:58:49 UTC) #16
commit-bot: I haz the power
7 years, 11 months ago (2013-01-22 08:30:34 UTC) #17
Message was sent while issue was closed. 
Change committed as 177983

Powered by Google App Engine
This is Rietveld 408576698