Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1465)

Issue 11883022: Move tests from test_shell_tests to content_unittests. (Closed)

Created:
7 years, 11 months ago by tony
Modified:
7 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pam+watch_chromium.org, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Move tests from test_shell_tests to content_unittests. These tests don't depend on webkit/tools/test_shell/test_shell_test.h and can be moved to content_unittests. Some tests were relying on the MessageLoop created by TestShell. I've updated them to create their own MessageLoop. BUG=126514 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177180

Patch Set 1 #

Patch Set 2 : disable cursor test on win aura #

Patch Set 3 : fix image decode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -16 lines) Patch
M content/content_tests.gypi View 1 1 chunk +9 lines, -0 lines 0 comments Download
M webkit/glue/resource_request_body_unittest.cc View 1 3 chunks +3 lines, -0 lines 0 comments Download
M webkit/glue/webcursor_unittest.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M webkit/glue/webkit_glue_unittest.cc View 1 2 4 chunks +22 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tony
7 years, 11 months ago (2013-01-14 23:06:46 UTC) #1
jam
lgtm
7 years, 11 months ago (2013-01-15 01:35:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/11883022/1
7 years, 11 months ago (2013-01-15 18:02:57 UTC) #3
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) build
7 years, 11 months ago (2013-01-15 19:06:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/11883022/23001
7 years, 11 months ago (2013-01-15 21:53:01 UTC) #5
commit-bot: I haz the power
Failed to trigger a try job on android_dbg HTTP Error 400: Bad Request
7 years, 11 months ago (2013-01-16 01:10:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/11883022/37002
7 years, 11 months ago (2013-01-16 01:11:00 UTC) #7
commit-bot: I haz the power
Retried try job too often on win for step(s) compile
7 years, 11 months ago (2013-01-16 03:28:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/11883022/37002
7 years, 11 months ago (2013-01-16 17:49:47 UTC) #9
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 18:45:35 UTC) #10
Message was sent while issue was closed.
Change committed as 177180

Powered by Google App Engine
This is Rietveld 408576698