Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 11883019: Fix PRESUBMIT.py for build/android/buildbot (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_device_steps.py
diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py
index b68928dab9d66227045dceb0eba08ed6482dac01..51e6d5e92a5b8ca37012f800dcd9b73a041f1971 100755
--- a/build/android/buildbot/bb_device_steps.py
+++ b/build/android/buildbot/bb_device_steps.py
@@ -98,9 +98,13 @@ def RebootDeviceSafe(device):
def RebootDevices():
"""Reboot all attached and online devices."""
buildbot_report.PrintNamedStep('Reboot devices')
+ # Early return here to avoid presubmit dependence on adb,
+ # which might not exist in this checkout.
+ if TESTING:
+ return
devices = android_commands.GetAttachedDevices()
print 'Rebooting: %s' % devices
- if devices and not TESTING:
+ if devices:
pool = multiprocessing.Pool(len(devices))
results = pool.map_async(RebootDeviceSafe, devices).get(99999)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698