Issue 11883019: Fix PRESUBMIT.py for build/android/buildbot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11883019: Fix PRESUBMIT.py for build/android/buildbot (Closed)

Created:
7 years, 11 months ago by Isaac (away)

Modified:
7 years, 11 months ago

Reviewers:
Yaron

CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, Mike Stip (use stip instead)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix PRESUBMIT.py for build/android/buildbot The code was making a call to android_commands.py, which relied on a copy of adb existing in the path. The CQ bot does not have third_party/android_tools, and in general it seems advantageous to not require a full checkout for syntax checks. NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176723

Patch Set 1 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	build/android/buildbot/bb_device_steps.py	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/11883019/2001

7 years, 11 months ago (2013-01-14 21:29:57 UTC) #3

Message was sent while issue was closed.

Change committed as 176723

Expand Messages | Collapse Messages