Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1857)

Unified Diff: dart.gyp

Issue 11883013: Refactored OpenGL embedder that works on Android, Mac or Linux. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/dart-runtime.gyp » ('j') | runtime/dart-runtime.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart.gyp
===================================================================
--- dart.gyp (revision 16976)
+++ dart.gyp (working copy)
@@ -122,12 +122,26 @@
'samples/android_sample/android_sample.gyp:android_sample',
],
},
vsm 2013/01/14 21:31:40 Note, if you add an extra {} clause, it's the else
gram 2013/01/16 01:49:16 I saw that but I find it more readable expanded ou
- ],
- ['OS!="android"', {
+ ],
+ ['OS=="win"', {
'dependencies': [
'samples/sample_extension/sample_extension.gyp:sample_extension',
],
},
+ ],
+ ['OS=="mac"', {
vsm 2013/01/14 21:31:40 I see "and", but not "or" in the chrome gyp files.
gram 2013/01/16 01:49:16 I used or elsewhere and it seemed to work so I'll
+ 'dependencies': [
+ 'samples/sample_extension/sample_extension.gyp:sample_extension',
+ 'samples/mobile_emulator_sample/mobile_emulator_sample.gyp:mobile_emulator_sample',
+ ],
+ },
+ ],
+ ['OS=="linux"', {
+ 'dependencies': [
+ 'samples/sample_extension/sample_extension.gyp:sample_extension',
+ 'samples/mobile_emulator_sample/mobile_emulator_sample.gyp:mobile_emulator_sample',
+ ],
+ },
]
],
},
« no previous file with comments | « no previous file | runtime/dart-runtime.gyp » ('j') | runtime/dart-runtime.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698