Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Unified Diff: chrome/common/extensions/extension.h

Issue 11882025: Move "oauth2" manifest key parsing out of Extension class. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.h
===================================================================
--- chrome/common/extensions/extension.h (revision 179928)
+++ chrome/common/extensions/extension.h (working copy)
@@ -55,8 +55,6 @@
struct ActionInfo;
class PermissionSet;
-typedef std::set<std::string> OAuth2Scopes;
-
// Represents a Chrome extension.
class Extension : public base::RefCountedThreadSafe<Extension> {
public:
@@ -133,17 +131,6 @@
std::string mime_type;
};
- // OAuth2 info included in the extension.
- struct OAuth2Info {
- OAuth2Info();
- ~OAuth2Info();
-
- OAuth2Scopes GetScopesAsSet();
-
- std::string client_id;
- std::vector<std::string> scopes;
- };
-
// A base class for parsed manifest data that APIs want to store on
// the extension. Related to base::SupportsUserData, but with an immutable
// thread-safe interface to match Extension.
@@ -567,7 +554,6 @@
}
bool incognito_split_mode() const { return incognito_split_mode_; }
bool offline_enabled() const { return offline_enabled_; }
- const OAuth2Info& oauth2_info() const { return oauth2_info_; }
bool wants_file_access() const { return wants_file_access_; }
int creation_flags() const { return creation_flags_; }
bool from_webstore() const { return (creation_flags_ & FROM_WEBSTORE) != 0; }
@@ -770,9 +756,6 @@
void(UserScript::*add_method)(const std::string& glob),
UserScript* instance);
- // Helper method that loads the OAuth2 info from the 'oauth2' manifest key.
- bool LoadOAuth2Info(string16* error);
-
// Returns true if the extension has more than one "UI surface". For example,
// an extension that has a browser action and a page action.
bool HasMultipleUISurfaces() const;
@@ -967,9 +950,6 @@
// Should this app be shown in the browser New Tab Page.
bool display_in_new_tab_page_;
- // The OAuth2 client id and scopes, if specified by the extension.
- OAuth2Info oauth2_info_;
-
// Whether the extension has host permissions or user script patterns that
// imply access to file:/// scheme URLs (the user may not have actually
// granted it that access).
« no previous file with comments | « chrome/common/extensions/api/identity/oauth2_manifest_handler.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698