Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3718)

Unified Diff: chrome/common/extensions/extension.h

Issue 11882025: Move "oauth2" manifest key parsing out of Extension class. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.h
===================================================================
--- chrome/common/extensions/extension.h (revision 176209)
+++ chrome/common/extensions/extension.h (working copy)
@@ -58,8 +58,6 @@
class Manifest;
class PermissionSet;
-typedef std::set<std::string> OAuth2Scopes;
-
// Represents a Chrome extension.
class Extension : public base::RefCountedThreadSafe<Extension> {
public:
@@ -175,17 +173,6 @@
std::string mime_type;
};
- // OAuth2 info included in the extension.
- struct OAuth2Info {
- OAuth2Info();
- ~OAuth2Info();
-
- OAuth2Scopes GetScopesAsSet();
-
- std::string client_id;
- std::vector<std::string> scopes;
- };
-
struct ActionInfo {
explicit ActionInfo();
~ActionInfo();
@@ -731,7 +718,6 @@
}
bool incognito_split_mode() const { return incognito_split_mode_; }
bool offline_enabled() const { return offline_enabled_; }
- const OAuth2Info& oauth2_info() const { return oauth2_info_; }
const std::vector<webkit_glue::WebIntentServiceData>&
intents_services() const {
return intents_services_;
@@ -967,9 +953,6 @@
ActionInfo::Type action_type,
string16* error);
- // Helper method that loads the OAuth2 info from the 'oauth2' manifest key.
- bool LoadOAuth2Info(string16* error);
-
// Returns true if the extension has more than one "UI surface". For example,
// an extension that has a browser action and a page action.
bool HasMultipleUISurfaces() const;
@@ -1197,9 +1180,6 @@
// Should this app be shown in the browser New Tab Page.
bool display_in_new_tab_page_;
- // The OAuth2 client id and scopes, if specified by the extension.
- OAuth2Info oauth2_info_;
-
// List of intent services that this extension provides, if any.
std::vector<webkit_glue::WebIntentServiceData> intents_services_;

Powered by Google App Engine
This is Rietveld 408576698