Implement 'Create Shortcuts' menu item on Mac.

Implement 'Create Shortcuts' menu item on Mac.

This implements the 'Create Shortcuts' behaviour present on Windows, though
without any dialog or options for where to create the shortcut (it always goes
in /Applications).

BUG=168080
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177094

[jeremya, 2013-01-15 06:35:02]

rsesek- c/b/ui/cocoa
estade- ntp4
sail- FYI

[sail, 2013-01-15 15:17:38]

lgtm

https://codereview.chromium.org/11881045/diff/1/chrome/browser/ui/cocoa/brows...
File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right):

https://codereview.chromium.org/11881045/diff/1/chrome/browser/ui/cocoa/brows...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:571:
ShellIntegration::ShortcutInfo shortcut_info;
Could you add a comment that normally you'd want to show a dialog (as per the
function name).
But you don't because on Mac you always create a shortcut in /Applications.

[Robert Sesek, 2013-01-15 15:18:14]

https://codereview.chromium.org/11881045/diff/1/chrome/browser/ui/cocoa/brows...
File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right):

https://codereview.chromium.org/11881045/diff/1/chrome/browser/ui/cocoa/brows...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:575:
shortcut_info.create_on_desktop = true;
The Desktop, really?

[sail, 2013-01-15 15:22:02]

https://codereview.chromium.org/11881045/diff/1/chrome/browser/ui/cocoa/brows...
File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right):

https://codereview.chromium.org/11881045/diff/1/chrome/browser/ui/cocoa/brows...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:575:
shortcut_info.create_on_desktop = true;
On 2013/01/15 15:18:14, rsesek wrote:
> The Desktop, really?

Not really, we only publish to /Applications (see CL description). Agree that
this could use some explanation in comments.

[Evan Stade, 2013-01-15 19:54:15]

lgtm

[jeremya, 2013-01-16 02:51:51]

https://codereview.chromium.org/11881045/diff/1/chrome/browser/ui/cocoa/brows...
File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right):

https://codereview.chromium.org/11881045/diff/1/chrome/browser/ui/cocoa/brows...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:571:
ShellIntegration::ShortcutInfo shortcut_info;
On 2013/01/15 15:17:39, sail wrote:
> Could you add a comment that normally you'd want to show a dialog (as per the
> function name).
> But you don't because on Mac you always create a shortcut in /Applications.

Done.

https://codereview.chromium.org/11881045/diff/1/chrome/browser/ui/cocoa/brows...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:575:
shortcut_info.create_on_desktop = true;
On 2013/01/15 15:22:02, sail wrote:
> On 2013/01/15 15:18:14, rsesek wrote:
> > The Desktop, really?
> 
> Not really, we only publish to /Applications (see CL description). Agree that
> this could use some explanation in comments.

Actually the shortcut creator for mac totally ignores all these flags, so I just
removed this code.

[commit-bot: I haz the power, 2013-01-16 02:57:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/11881045/9001

[commit-bot: I haz the power, 2013-01-16 05:41:57]

Change committed as 177094