Remove all ancillary chunks except for tRNS

Remove all ancillary chunks except for tRNS

R=thakis@chromium.org
BUG=150046
TEST=none
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176591

[Nico, 2013-01-12 02:59:24]

https://codereview.chromium.org/11881012/diff/1/build/sanitize-png-files.sh
File build/sanitize-png-files.sh (right):

https://codereview.chromium.org/11881012/diff/1/build/sanitize-png-files.sh#n...
build/sanitize-png-files.sh:23: -rem mkTS -rem iTXt -rem tEXt -rem zTXt -rem
tIME \
Looking through the pngcrush souce, it looks like "-rem alla" will remove all
auxiliary chunks, including text and gamma. Should we just use that instead of
this list?

[oshima, 2013-01-12 03:19:24]

On 2013/01/12 02:59:24, Nico wrote:
> https://codereview.chromium.org/11881012/diff/1/build/sanitize-png-files.sh
> File build/sanitize-png-files.sh (right):
> 
>
https://codereview.chromium.org/11881012/diff/1/build/sanitize-png-files.sh#n...
> build/sanitize-png-files.sh:23: -rem mkTS -rem iTXt -rem tEXt -rem zTXt -rem
> tIME \
> Looking through the pngcrush souce, it looks like "-rem alla" will remove all
> auxiliary chunks, including text and gamma. Should we just use that instead of
> this list?

That's good to know. Will do.

[oshima, 2013-01-12 18:48:37]

uploaded new patch. PTAL

[Nico, 2013-01-12 19:31:25]

On 2013/01/12 18:48:37, oshima wrote:
> uploaded new patch. PTAL

I saw the "except tRNS" in the description. We do have files without alpha
channel that use tRNS:

  for f in $(find chrome/app/theme/ -name '*.png'); do if file $f | grep -v RGBA
| grep -qv gray+alpha; then grep tRNS -l $f; fi; done

I verified that pngcrush keeps tRNS chunks around with -rem alla, so this lgtm.
Maybe you want to add a comment that says "alla strips all auxiliary chunks
except tRNS".

[oshima, 2013-01-12 19:37:20]

On 2013/01/12 19:31:25, Nico wrote:
> On 2013/01/12 18:48:37, oshima wrote:
> > uploaded new patch. PTAL
> 
> I saw the "except tRNS" in the description. We do have files without alpha
> channel that use tRNS:
> 
>   for f in $(find chrome/app/theme/ -name '*.png'); do if file $f | grep -v
RGBA
> | grep -qv gray+alpha; then grep tRNS -l $f; fi; done
> 
> I verified that pngcrush keeps tRNS chunks around with -rem alla, so this
lgtm.
> Maybe you want to add a comment that says "alla strips all auxiliary chunks
> except tRNS".

done

[commit-bot: I haz the power, 2013-01-12 19:37:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/11881012/7002

[commit-bot: I haz the power, 2013-01-12 20:06:55]

Change committed as 176591