Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Side by Side Diff: src/isolate.cc

Issue 11880018: Reland r13188, r13194, r13256 (Deferred formatting of error stack trace during GC). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap-inl.h ('k') | src/list.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 617 matching lines...) Expand 10 before | Expand all | Expand 10 after
628 Handle<Smi> offset(Smi::FromInt(frames[i].offset())); 628 Handle<Smi> offset(Smi::FromInt(frames[i].offset()));
629 elements->set(cursor++, *recv); 629 elements->set(cursor++, *recv);
630 elements->set(cursor++, *fun); 630 elements->set(cursor++, *fun);
631 elements->set(cursor++, *code); 631 elements->set(cursor++, *code);
632 elements->set(cursor++, *offset); 632 elements->set(cursor++, *offset);
633 } 633 }
634 } 634 }
635 } 635 }
636 Handle<JSArray> result = factory()->NewJSArrayWithElements(elements); 636 Handle<JSArray> result = factory()->NewJSArrayWithElements(elements);
637 result->set_length(Smi::FromInt(cursor)); 637 result->set_length(Smi::FromInt(cursor));
638 heap()->error_object_list()->Add(*error_object);
638 return result; 639 return result;
639 } 640 }
640 641
641 642
642 void Isolate::CaptureAndSetDetailedStackTrace(Handle<JSObject> error_object) { 643 void Isolate::CaptureAndSetDetailedStackTrace(Handle<JSObject> error_object) {
643 if (capture_stack_trace_for_uncaught_exceptions_) { 644 if (capture_stack_trace_for_uncaught_exceptions_) {
644 // Capture stack trace for a detailed exception message. 645 // Capture stack trace for a detailed exception message.
645 Handle<String> key = factory()->hidden_stack_trace_symbol(); 646 Handle<String> key = factory()->hidden_stack_trace_symbol();
646 Handle<JSArray> stack_trace = CaptureCurrentStackTrace( 647 Handle<JSArray> stack_trace = CaptureCurrentStackTrace(
647 stack_trace_for_uncaught_exceptions_frame_limit_, 648 stack_trace_for_uncaught_exceptions_frame_limit_,
(...skipping 1563 matching lines...) Expand 10 before | Expand all | Expand 10 after
2211 2212
2212 #ifdef DEBUG 2213 #ifdef DEBUG
2213 #define ISOLATE_FIELD_OFFSET(type, name, ignored) \ 2214 #define ISOLATE_FIELD_OFFSET(type, name, ignored) \
2214 const intptr_t Isolate::name##_debug_offset_ = OFFSET_OF(Isolate, name##_); 2215 const intptr_t Isolate::name##_debug_offset_ = OFFSET_OF(Isolate, name##_);
2215 ISOLATE_INIT_LIST(ISOLATE_FIELD_OFFSET) 2216 ISOLATE_INIT_LIST(ISOLATE_FIELD_OFFSET)
2216 ISOLATE_INIT_ARRAY_LIST(ISOLATE_FIELD_OFFSET) 2217 ISOLATE_INIT_ARRAY_LIST(ISOLATE_FIELD_OFFSET)
2217 #undef ISOLATE_FIELD_OFFSET 2218 #undef ISOLATE_FIELD_OFFSET
2218 #endif 2219 #endif
2219 2220
2220 } } // namespace v8::internal 2221 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/heap-inl.h ('k') | src/list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698