Issue 11880018: Reland r13188, r13194, r13256 (Deferred formatting of error stack trace during GC).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11880018: Reland r13188, r13194, r13256 (Deferred formatting of error stack trace during GC). (Closed)

Created:
7 years, 11 months ago by Yang

Modified:
7 years, 11 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Reland r13188, r13194, r13256 (Deferred formatting of error stack trace during GC). BUG= Committed: https://code.google.com/p/v8/source/detail?r=13371

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+491 lines, -60 lines)			Patch
M	src/api.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	src/handles.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/heap.h	View		4 chunks	+42 lines, -0 lines	0 comments	Download
M	src/heap.cc	View		7 chunks	+120 lines, -0 lines	0 comments	Download
M	src/heap-inl.h	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/isolate.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/list.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/list-inl.h	View		2 chunks	+10 lines, -1 line	0 comments	Download
M	src/mark-compact.cc	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	src/messages.js	View	1	8 chunks	+83 lines, -40 lines	0 comments	Download
M	src/runtime.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/runtime.cc	View		1 chunk	+35 lines, -5 lines	0 comments	Download
M	test/cctest/test-decls.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-heap.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	test/message/overwritten-builtins.out	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/mjsunit/eval-stack-trace.js	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	test/mjsunit/stack-traces.js	View		1 chunk	+39 lines, -1 line	0 comments	Download
A	test/mjsunit/stack-traces-gc.js	View		1 chunk	+119 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Yang

This set of CLs has been reverted previously because of WebKit failures. Those have been ...

7 years, 11 months ago (2013-01-14 10:58:47 UTC) #1

Michael Starzinger

7 years, 11 months ago (2013-01-14 12:42:06 UTC) #2

LGTM (rubber-stamped patch set 1 and reviewed patch set 2).