Issue 11880017: Remove some ascii checks in advance of latin-1 release

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11880017: Remove some ascii checks in advance of latin-1 release (Closed)

Created:
7 years, 11 months ago by drcarney

Modified:
7 years, 11 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove some ascii checks in advance of latin-1 release BUG= Committed: https://code.google.com/p/v8/source/detail?r=13399

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -57 lines)			Patch
M	src/heap-inl.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/liveobjectlist.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/v8utils.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/v8utils.cc	View	1 chunk	+0 lines, -51 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM. I'll Related note: I was wondering about Live Object Lists before. It doesn't seem ...

7 years, 11 months ago (2013-01-16 12:52:05 UTC) #1

Yang

7 years, 11 months ago (2013-01-16 12:52:22 UTC) #2

On 2013/01/16 12:52:05, Yang wrote:
> LGTM. I'll 
> 
> Related note: I was wondering about Live Object Lists before. It doesn't seem
to
> be tested or used. I'll do some research on this. Maybe we can rip it out
> entirely and everything it exclusively uses (like
MemoryMappedExternalResource).

What I meant to say is that I'll land this CL.

Expand Messages | Collapse Messages